fix(push): create the remote bookmark on first push of a new branch #184

Merged

gmackie merged 1 commit from fix/push-allow-new into main

2026-08-02 21:44:13 +00:00

gmackie commented

2026-08-02 21:37:05 +00:00

Owner

What

forge push now creates the remote bookmark on the first push of a new branch (item #4 of the forge-CLI DX field report).

Why

It shelled out to jj git push without --allow-new, so a fresh branch failed with "Refusing to create new remote bookmark. Nothing changed." — breaking the documented changeset -> push -> pr flow on new branches.

Change

The jj push path adds --allow-new (unless the caller already passed it), via a pure jjPushArgs helper (unit-tested). Ryu/git paths unchanged. (jj deprecation-warns the flag but it still works; a brand-new local bookmark can't be pre-tracked.)

Verification

Go build/vet green; TestJJPushArgs 2/2.

Field report: item #4.

## What `forge push` now creates the remote bookmark on the first push of a new branch (item #4 of the forge-CLI DX field report). ## Why It shelled out to `jj git push` without `--allow-new`, so a fresh branch failed with *"Refusing to create new remote bookmark. Nothing changed."* — breaking the documented changeset -> push -> pr flow on new branches. ## Change The jj push path adds `--allow-new` (unless the caller already passed it), via a pure `jjPushArgs` helper (unit-tested). Ryu/git paths unchanged. (jj deprecation-warns the flag but it still works; a brand-new local bookmark can't be pre-tracked.) ## Verification Go `build`/`vet` green; `TestJJPushArgs` 2/2. Field report: item #4.

gmackie added 1 commit

2026-08-02 21:37:05 +00:00

fix(push): create the remote bookmark on first push of a new branch

CI / gitleaks (pull_request) Successful in 16s

Details

forgegraph/ci CI passed

CI / ci (pull_request) Successful in 6m21s

Details

13b6fef539

`forge push` built `jj git push` without --allow-new, so the first push of a
fresh branch failed with 'Refusing to create new remote bookmark. Nothing
changed.' and the changeset -> push -> pr flow dead-ended. It now adds
--allow-new for the jj path (unless the caller already passed it).

gmackie merged commit 5604d222d8 into main

2026-08-02 21:44:13 +00:00

gmackie deleted branch fix/push-allow-new

2026-08-02 21:44:13 +00:00

gmackie referenced this pull request from a commit

2026-08-02 21:44:13 +00:00

Merge pull request 'fix(push): create the remote bookmark on first push of a new branch' (#184) from fix/push-allow-new into main